Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32107 )
Change subject: src/mb/Kconfig: Fix PCI subsystem IDs
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32107/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32107/3//COMMIT_MSG@16
PS3, Line 16: one of the three reasons below:
Hmm.. which part wasn't true? I added the paragraph, too late now i guess.
Three boards were non-lynxpoint, had `1e.0 on` and non-zero setting.
I commented on two of them, the third had dt and Kconfig in sync.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72bba8406eea4a264e36cc9bcf467cf5cfbed379
Gerrit-Change-Number: 32107
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 19 Apr 2019 18:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment