Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39710 )
Change subject: soc/intel/tigerlake: Implement CHIPSET_LOCKDOWN
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39710/10/src/soc/intel/tigerlake/fs...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39710/10/src/soc/intel/tigerlake/fs...
PS10, Line 113: CHIPSET_LOCKDOWN_COREBOOT
Why does the CHIPSET_LOCKDOWN_COREBOOT case appear to unlock everything and the else case lock down […]
The condistion CHIPSET_LOCKDOWN_COREBOOT hear means do not lockdown inside FSP and Coreboot will lockdown. And this is code for providing parameters to FSP.
Actual lockdown implementation is in src/soc/intel/common/pch/lockdown/lockdown.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63cec8a718285f424914e426d0399ed821588dfd
Gerrit-Change-Number: 39710
Gerrit-PatchSet: 13
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 00:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment