Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41471 )
Change subject: soc/intel/broadwell: Mask lower 20 bits of TOLUD and TOLM in systemagent.asl
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41471/1/src/soc/intel/broadwell/acp...
File src/soc/intel/broadwell/acpi/systemagent.asl:
https://review.coreboot.org/c/coreboot/+/41471/1/src/soc/intel/broadwell/acp...
PS1, Line 153: And (Local0, ShiftLeft(0xfff, 20), Local0)
Why use the old syntax here?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11b3ef8deda21930998471ab6e712da4c62f5b02
Gerrit-Change-Number: 41471
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 17 May 2020 04:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment