Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38714 )
Change subject: trogdor: Latch GPIO interrupt support ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/board.h:
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 29: GPIO_PULLNONE = 0,
code indent should use tabs where possible
These don't need to be here, just use GPIO_PULL_UP from <soc/gpio.h>. (Also, like the bot says, please always indent with tabs, not spaces.)
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/bootblock.c:
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 27: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULLUP); Sorry, on second thought, this should go into chromeos.c after all...
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.c:
https://review.coreboot.org/c/coreboot/+/38714/4/src/mainboard/google/trogdo... PS4, Line 32: gpio_input_pullup(GPIO_H1_AP_INT); ...and replace this line here.