Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38737 )
Change subject: soc/tigerlake: Update FSP UPDs to turn on USB4/TBT ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38737/1/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/38737/1/src/soc/intel/tigerlake/fsp... PS1, Line 139: 4 ARRAY_SIZE()
https://review.coreboot.org/c/coreboot/+/38737/1/src/soc/intel/tigerlake/fsp... PS1, Line 140: params->ITbtPcieRootPortEn[i] = 1; This should be a devicetree config option that we can associate with the device itself. We likely could utilize the enable field of the device in question.
https://review.coreboot.org/c/coreboot/+/38737/1/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/38737/1/src/soc/intel/tigerlake/rom... PS1, Line 134: m_cfg->TcssItbtPcie0En = 1; Same comment as my other one relating to driving these values from devicetree.