Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34990 )
Change subject: mediatek/mt8183: Use different DRAM frequencies for eMCP DDR ......................................................................
Patch Set 28:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34990/28/src/soc/mediatek/mt8183/em... File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34990/28/src/soc/mediatek/mt8183/em... PS28, Line 22: enum { : LP4X_LOW, : LP4X_MIDDLE, : LP4X_HIGH, : LP4X_FREQ_NUM, : }; : : #if CONFIG(MT8183_DRAM_EMCP) : static u8 lp4x_freq[LP4X_FREQ_NUM] = { : [LP4X_LOW] = LP4X_DDR1600, : [LP4X_MIDDLE] = LP4X_DDR3200, : [LP4X_HIGH] = LP4X_DDR3600, : }; : #else : static u8 lp4x_freq[LP4X_FREQ_NUM] = { : [LP4X_LOW] = LP4X_DDR1600, : [LP4X_MIDDLE] = LP4X_DDR2400, : [LP4X_HIGH] = LP4X_DDR3200, : }; : #endif will it be better if we do this inside a function?
enum lp4x_frequency { LP4X_LOW, LP4X_MIDDLE, LP4X_HIGH, }
static u32 get_lp4x_frequency(enum lp4x_frequency freq) { static const u8 const freq_table[] = { [LP4X_LOW] . ..; }; static const u8 const freq_emcp[] = { []. ... };
if (CONFIG(MT8183_DRAM_EMCP)) return freq_emcp[freq]; else return freq_table[freq]; }