build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )
Change subject: mb/google/asurada: Implement board-specific regulator controls. ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... PS7, Line 21: switch(regulator) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... PS7, Line 37: switch(regulator) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/46406/7/src/mainboard/google/asurad... PS7, Line 79: if (regulator == MTK_REGULATOR_VDD1) { braces {} are not necessary for single statement blocks