Mengqi Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32461 )
Change subject: mediatek: Add SPI tick_dly setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32461/2/src/soc/mediatek/mt8183/spi.c
File src/soc/mediatek/mt8183/spi.c:
https://review.coreboot.org/#/c/32461/2/src/soc/mediatek/mt8183/spi.c@125
PS2, Line 125: clrsetbits_le32(®s->spi_cfg1_reg, SPI_CFG1_CS_IDLE_MASK,
nit: merge both into a single clrsetbits_le32() like you did for the 8173 case?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie49fc3efe2a4a6dcdf2a2fc4c91b47e35d4f086e
Gerrit-Change-Number: 32461
Gerrit-PatchSet: 2
Gerrit-Owner: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 May 2019 11:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment