Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33190 )
Change subject: soc/intel/icelake: Replace PCI device LPC to ESPI as per EDS ......................................................................
Patch Set 6:
(5 comments)
I am curious about the motivation behind the change. It doesn't look like you have gotten rid of all the lpc references anyways?
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/acpi.c File src/soc/intel/icelake/acpi.c:
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/acpi.c@172 PS6, Line 172: PCH_DEV_ESPI These should be changed to SA_DEV_ROOT? There is nothing specific to lpc/espi device here.
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/acpi.c@201 PS6, Line 201: gnvs->pm1i = -1; Same here.
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/bootblock/repo... File src/soc/intel/icelake/bootblock/report_platform.c:
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/bootblock/repo... PS6, Line 49: lpcid espi_id?
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/bootblock/repo... PS6, Line 174: lpcid espi_id
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/include/soc/pc... File src/soc/intel/icelake/include/soc/pci_devs.h:
https://review.coreboot.org/#/c/33190/6/src/soc/intel/icelake/include/soc/pc... PS6, Line 185: PCH_DEV_LPC Why was this retained?