EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level ......................................................................
Patch Set 13:
Patch Set 13:
Patch Set 13:
Patch Set 13:
Patch Set 13:
@Subrata, I found the issue here. APL use the common platform.asl but not use the common globalnvs.asl that cause this issue. How can we fix this?
looks like its common vs specific SOC changes issue
now we have 2 option
Do you really need to save and restore GPIO PM setting in _PTS and _WAK, because _PTS/_WAK will only call for S5/S3 case where anyway your bootblock changes are in place to fix GPIO PM issue, isn't its duplicate ? i guess you have to only bother about MPTS/MWAK ?
Like SKL has its own platform.asl rather using common one. Its not feasible to make GPIO PM override feature flag for APL where this feature doesn't exist.
I think the bootblock is called when resume not when suspend. _WAK is not needed, but _PTS still needed.
@Eric, i didn't get this, if _WAK is not required when why you think _PTS is required ? Can you please let me know what you want achieve using _PTS ? May be i'm missing something here :(
We want enable PM before suspend, this is why we need _PTS. I think we don't have S3 handler in the coreboot. And for the S3 resume it will call bootblock and this will do the things we want do in _WAK which is store the PM bits from device tree.