[coreboot-gerrit] Change in coreboot[master]: assert.h: Simplify dead_code()

[Nico Huber (Code Review)]

Hello Julius Werner, Felix Held,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/40240

to review the following change.

Change subject: assert.h: Simplify dead_code()
......................................................................

assert.h: Simplify dead_code()

It turns out the linker's error message already includes the line
number of the dead_code() invocation. If we don't include the line
number in the identifier for our undefined reference, we don't need
individual identifiers at all and can work with a single, global
declaration.

Change-Id: Ib63868ce3114c3f839867a3bfb1b03bdb6facf16
Signed-off-by: Nico Huber 
---
M src/include/assert.h
1 file changed, 3 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/40240/1

diff --git a/src/include/assert.h b/src/include/assert.h
index 492629d..7252ab6 100644
--- a/src/include/assert.h
+++ b/src/include/assert.h
@@ -52,15 +52,10 @@
  * The error message when this hits will look like this:
  *
  * ramstage/lib/bootmode.o: In function `display_init_required':
- * bootmode.c:42: undefined reference to `dead_code_assertion_failed_at_line_42'
+ * bootmode.c:42: undefined reference to `_dead_code_assertion_failed'
  */
-#define __dead_code(tag, line) do { \
-	extern void dead_code_assertion_failed##tag##_at_line_##line(void) \
-		__attribute__((noreturn)); \
-	dead_code_assertion_failed##tag##_at_line_##line(); \
-} while (0)
-#define _dead_code(tag, line) __dead_code(tag, line)
-#define dead_code(tag) _dead_code(tag, __LINE__)
+extern void _dead_code_assertion_failed(void) __attribute__((noreturn));
+#define dead_code() _dead_code_assertion_failed()

/* This can be used in the context of an expression of type 'type'. */
 #define dead_code_t(type) ({ \