Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36777 )
Change subject: cpu/x86/lapic: Cleanup code ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@7 PS1, Line 7: Cleanup Clean up
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@7 PS1, Line 7: cpu/x86/lapic: Cleanup code Too generic. Maybe:
cpu/x86/lapic: Support x86_64 and clean up code
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@9 PS1, Line 9: interrupts : in qemu Do they need to be 32-bit?
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@14 PS1, Line 14: again Did it ever work before with x86_64?
https://review.coreboot.org/c/coreboot/+/36777/1//COMMIT_MSG@14 PS1, Line 14: working work