Attention is currently required from: Angel Pons, Václav Straka.
Nicholas Chin has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400 ......................................................................
Patch Set 10:
(7 comments)
Patchset:
PS10: Just some small things, otherwise looks good to me.
File Documentation/mainboard/hp/pro_3500_series.md:
https://review.coreboot.org/c/coreboot/+/85825/comment/541729c2_19db63a3?usp... : PS10, Line 10: When using MrChromebox edk2 with secure boot build in, the : board will hang on each boot for about 20 seconds before continuing. I'm assuming you tested this and found that it was no longer true?
File src/mainboard/hp/pro_3500_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/85825/comment/50c03947_0c211c7e?usp... : PS10, Line 12: select MAINBOARD_USES_IFD_GBE_REGION Note to anyone else looking at this: This will no longer be selected for the 3500 variant, but seems to have been a mistake in the first place based on the IFD layout listed in the original 3500 documentation.
File src/mainboard/hp/pro_3x00_series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/85825/comment/fe214bc0_771c8ea2?usp... : PS10, Line 37: 2 0 Enable : 2 1 Disable Not used; can be removed.
File src/mainboard/hp/pro_3x00_series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/85825/comment/91ce601b_624b3692?usp... : PS10, Line 3: define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB These can be dropped, as it's only used by the Thinkpad H8 ACPI code. *Note to self: Fix that in autoport*
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85825/comment/e4b7de78_f17bf989?usp... : PS10, Line 5: I would drop the blank line here as I don't think it adds much.
File src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85825/comment/4755b202_311d954c?usp... : PS10, Line 5: Same here, drop the blank line