[coreboot-gerrit] Change in coreboot[master]: src/*: Make PCI ID macro names shorter

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39331 )

Change subject: src/*: Make PCI ID macro names shorter
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39331/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39331/1//COMMIT_MSG@8 
PS1, Line 8: 
           : This patch shortens macro names containing PCI_{DEVICE,VENDOR}_ID_
           : with PCI_{DID,VID}_.
Hi Felix,  I appreciate the effort you're putting in to make the coreboot codebase better.

Please be aware of the impact that this sort of change makes on trying to maintain coreboot for users not on the current branch.  Say for example that someone wants to port something back to the 4.9 branch.  After this sort of change, that's much harder.  If it touches one of these values, they now have to update this as well.

Is this change worth that?  I'm not going to try to answer that question, it's just something to keep in mind when making codebase-wide changes.  Something that seems relatively simple and innocuous can have wide-reaching effects.