Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37063 )
Change subject: arch/x86/cache.h: Use ENV_CACHE_AS_RAM macro
......................................................................
Patch Set 5: Code-Review+1
Patch Set 5: Code-Review+1
It would make sense to remove implementation of car_active() here already to see what it did and why this commit is fine.
Agreed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b088a04165bb24b9ebcebc1580a96ce0fdfcc8
Gerrit-Change-Number: 37063
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 21:37:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment