Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45965 )
Change subject: mb/google/zork: Add EC device wakeup for morphius ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/45965/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45965/2//COMMIT_MSG@13 PS2, Line 13: None zork
https://review.coreboot.org/c/coreboot/+/45965/2//COMMIT_MSG@14 PS2, Line 14: None I think Denis tested that wake works using trackpoint? It would be good to capture that in the commit message.
https://review.coreboot.org/c/coreboot/+/45965/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/include/variant/ec.h:
https://review.coreboot.org/c/coreboot/+/45965/2/src/mainboard/google/zork/v... PS2, Line 11: Enable trackpoint S3 wakeups nit: I think this needs to go just above MAINBOARD_EC_S3_DEVICE_EVENTS on line 19?