Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41375 )
Change subject: nb/intel/sandybridge: Do not hardcode resource indices
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41375/1/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41375/1/src/northbridge/intel/sandy...
PS1, Line 138: 3
Why 3?
Because I want to preserve the original behavior, and that's what the code starts off with.
Yes, I don't like it. But looks like other chipsets (x4x) do the same thing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8719a1a5973a10531cf11b3307652212cb3d4895
Gerrit-Change-Number: 41375
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 14 May 2020 16:34:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment