HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45759 )
Change subject: soc/intel/alderlake/ramstage: Do initial SoC commit till ramstage ......................................................................
Patch Set 3:
(11 comments)
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/acp... PS3, Line 23: #include <string.h> <string.h> not used.
missing <stdint.h> and <stddef.h>
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/chi... File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/chi... PS3, Line 3: #include <console/console.h> not used?
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/inc... File src/soc/intel/alderlake/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/inc... PS3, Line 6: #include <intelblocks/msr.h> not used.
or is current file is supposed to indirectly include <intelblocks/msr.h> ?
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/inc... File src/soc/intel/alderlake/include/soc/me.h:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/inc... PS3, Line 10: u32 <stdint.h>
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/inc... File src/soc/intel/alderlake/include/soc/ramstage.h:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/inc... PS3, Line 6: #include <device/device.h> not used?
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/loc... File src/soc/intel/alderlake/lockdown.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/loc... PS3, Line 16: uint8_t <stdint.h>
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/pmc... File src/soc/intel/alderlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/pmc... PS3, Line 25: uint8_t <stdint.h>
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/pmu... File src/soc/intel/alderlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/pmu... PS3, Line 39: size_t <stddef.h>
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/pmu... PS3, Line 123: uint8_t <stdint.h>
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/smi... File src/soc/intel/alderlake/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/smi... PS3, Line 3: console/console.h> not used?
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/sou... File src/soc/intel/alderlake/soundwire.c:
https://review.coreboot.org/c/coreboot/+/45759/3/src/soc/intel/alderlake/sou... PS3, Line 48: size_t <stddef.h>