Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52304 )
Change subject: soc/amd/common/block/acpi: Fix the config to build gpio library ......................................................................
soc/amd/common/block/acpi: Fix the config to build gpio library
ACPI GPIO library should be built when SOC_AMD_COMMON_BLOCK_ACPI_GPIO is enabled. Fix the build rules. Also simplify the build rules for other ACPI components.
BUG=None TEST=Build and boot to OS in guybrush. Ensure that no errors are observed regarding GPIO operations while populating the ACPI tables.
Change-Id: I0c1dab421cb2feb7346718e1e23ed9d4a21d40cc Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com --- M src/soc/amd/common/block/acpi/Makefile.inc 1 file changed, 4 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/52304/1
diff --git a/src/soc/amd/common/block/acpi/Makefile.inc b/src/soc/amd/common/block/acpi/Makefile.inc index 1bec9e5..1355e21 100644 --- a/src/soc/amd/common/block/acpi/Makefile.inc +++ b/src/soc/amd/common/block/acpi/Makefile.inc @@ -1,14 +1,5 @@ -ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI),y) +all-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI) += acpi.c
-bootblock-y += acpi.c -verstage_x86-y += acpi.c -romstage-y += acpi.c -ramstage-y += acpi.c -postcar-y += acpi.c -smm-y += acpi.c - -ramstage-y += pm_state.c -ramstage-y += tables.c -ramstage-$(CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_GPIO) += gpio.c - -endif # CONFIG_SOC_AMD_COMMON_BLOCK_ACPI +ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI) += pm_state.c +ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI) += tables.c +ramstage-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPI_GPIO) += gpio.c