5 Nov
2020
5 Nov
'20
9:17 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47191 )
Change subject: mb/purism/librem_mini: Set unused GPIO pads to PAD_NC ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47191/4/src/mainboard/purism/librem... PS4, Line 205: /* GPP_D7 - NC */ : PAD_NC(GPP_D7, UP_20K),
nope; R526 is unstuff/nonpop
I found a hi... or midres image; U40 is unpop -> NC is right
--
To view, visit https://review.coreboot.org/c/coreboot/+/47191
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c2ab936256d0031d7a127fbeac42c8951a0b39f
Gerrit-Change-Number: 47191
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 21:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment