Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 )
Change subject: soc/intel/apl: Add ACPI for SMBus control ......................................................................
Patch Set 12:
Patch Set 12:
I would really like to understand this. I've tried your mAL10 port without this SMBus patch on Linux 4.19: SMBus works fine. For instance `decode-dimms` shows me the SPD info (didn't test nct7802 as I seem to lack the module).
I apologize for the delay. Yes, you're right, this also works with i2c-i801 driver on Linux.
$ sensors
coretemp-isa-0000 Adapter: ISA adapter Package id 0: +39.0°C (high = +110.0°C, crit = +110.0°C) Core 0: +39.0°C (high = +110.0°C, crit = +110.0°C) Core 1: +39.0°C (high = +110.0°C, crit = +110.0°C) Core 2: +40.0°C (high = +110.0°C, crit = +110.0°C) Core 3: +40.0°C (high = +110.0°C, crit = +110.0°C)
nct7802-i2c-5-2e Adapter: SMBus I801 adapter at efa0 in0: +3.35 V (min = +0.00 V, max = +4.09 V) in1: +1.91 V in3: +1.22 V (min = +0.00 V, max = +2.05 V) in4: +1.68 V (min = +0.00 V, max = +2.05 V) fan1: 0 RPM (min = 0 RPM) fan2: 0 RPM (min = 0 RPM) fan3: 0 RPM (min = 0 RPM) temp1: +41.1°C (low = +0.0°C, high = +85.0°C) (crit = +100.0°C) sensor = thermistor temp4: +43.0°C (low = +0.0°C, high = +85.0°C) (crit = +100.0°C) temp6: +0.0°C
But It seems to me that in the case of Windows, these methods are needed. Unfortunately I can not test right now.