Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39967 )
Change subject: soc/intel/common/pch/lockdown: Lock at end of BS_POST_DEVICE
......................................................................
Patch Set 2:
Patch Set 2:
I think this was done to not allow option roms to run while settings were unlocked.
Yes Aaron is right,as per recommendation, before 3rd party opromm, we need to lock down few chipset registers
is there any problem for pushing it out?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76cca20bc8dc2a7bdc5f16525919f7ef081df798
Gerrit-Change-Number: 39967
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 15:39:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment