Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35349 )
Change subject: drivers/intel/fsp2_0: Allocate cfg_region_size for UPD ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35349/2/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/35349/2/src/drivers/intel/fsp2_0/si... PS2, Line 43: (hdr->cfg_region_size) I think it should just die() if cfg_region_size is 0. I don't think it is normal to have that.
https://review.coreboot.org/c/coreboot/+/35349/2/src/drivers/intel/fsp2_0/si... PS2, Line 48: printk(BIOS_ERR, "FSP error: more UPD specified than allowed by header cfg_region_size\n"); Shouldn't this just die() here?