Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33060 )
Change subject: mb/google/hatch: Remove unused USB2 port5 from baseboard devicetree ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33060/1/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/hatch_whl/overridetree.cb:
https://review.coreboot.org/#/c/33060/1/src/mainboard/google/hatch/variants/... PS1, Line 35: register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC2)" # Type-C Port 0 : register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC2)" # Type-C Port 1 : register "usb2_ports[2]" = "USB2_PORT_SHORT(OC3)" # Type-A Port 0 : register "usb2_ports[3]" = "USB2_PORT_LONG(OC3)" # Type-A Port 1 : register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # BT : register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # WWAN : register "usb2_ports[6]" = "USB2_PORT_LONG(OC_SKIP)" # Camera : register "usb2_ports[7]" = "USB2_PORT_EMPTY" : register "usb2_ports[8]" = "USB2_PORT_EMPTY" : register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # CnVi BT : : register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC2)" # Type-C Port 0 : register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC2)" # Type-C Port 1 : register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC3)" # Type-A Port 0 : register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC3)" # Type-A Port 1 : register "usb3_ports[4]" = "USB3_PORT_DEFAULT(OC_SKIP)" # WWAN : register "usb3_ports[5]" = "USB3_PORT_EMPTY" Please only update items that differ from the baseboard device tree.
https://review.coreboot.org/#/c/33060/1/src/mainboard/google/hatch/variants/... PS1, Line 54: device pci 14.0 on : chip drivers/usb/acpi : register "desc" = ""Root Hub"" : register "type" = "UPC_TYPE_HUB" : device usb 0.0 on : chip drivers/usb/acpi : register "desc" = ""Left Type-C Port"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(1, 1)" : device usb 2.0 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-C Port 1"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 2.1 on end : end : chip drivers/usb/acpi : register "desc" = ""Left Type-A Port"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(1, 2)" : device usb 2.2 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-A Port 1"" : register "type" = "UPC_TYPE_A" : register "group" = "ACPI_PLD_GROUP(2, 2)" : device usb 2.3 on end : end : chip drivers/usb/acpi : register "desc" = ""Discrete bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" : device usb 2.4 on end : end : chip drivers/usb/acpi : register "desc" = ""WWAN"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.5 on end : end : chip drivers/usb/acpi : register "desc" = ""Camera"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.6 on end : end : chip drivers/usb/acpi : register "desc" = ""Integrated CnVi bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C14)" : device usb 2.9 on end : end : chip drivers/usb/acpi : register "desc" = ""Left Type-C Port"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(1, 1)" : device usb 3.0 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-C Port 1"" : register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" : register "group" = "ACPI_PLD_GROUP(2, 1)" : device usb 3.1 on end : end : chip drivers/usb/acpi : register "desc" = ""Left Type-A Port"" : register "type" = "UPC_TYPE_USB3_A" : register "group" = "ACPI_PLD_GROUP(1, 2)" : device usb 3.2 on end : end : chip drivers/usb/acpi : register "desc" = ""Right Type-A Port 1"" : register "type" = "UPC_TYPE_USB3_A" : register "group" = "ACPI_PLD_GROUP(2, 2)" : device usb 3.3 on end : end : chip drivers/usb/acpi : register "desc" = ""WWAN"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 3.4 on end : end : end : end : end # USB xHCI Am I missing something? Aren't these entries already in the baseboard device tree? If you're just keeping the bluetooth on port 10, then you don't need the other entries.