Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35887 )
Change subject: soc/intel/common/block/sa: Add compiletime error on undefined SA_PCIE_LENGTH ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35887/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/35887/2/src/soc/intel/common/block/... PS2, Line 56: default: NB. This will result in a wrong reservation. And I know at least some Linux versions use the E820 entry to figure the size (yes, ACPI missed to define a way to pass the size to the OS). I guess it's at least worth a warning. Or if we trust our Kconfig, just die().
Or, the long version without trusting Kconfig, trigger the compile-time error if it's not set to one of the three.
Hmmm, after writing this out. What happens with a dead_code() here and without the `#if`? Theoretically, the whole `switch` can be decided at compile-time.