Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32867 )
Change subject: device_tree: Match debug output format to dtc -O dts output
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32867/5/src/lib/device_tree.c
File src/lib/device_tree.c:
https://review.coreboot.org/#/c/32867/5/src/lib/device_tree.c@481
PS5, Line 481:
I mean, I don't know... […]
I think Google coding style suggests always doing two space for inline comment, while in this file you can find one space, tab, multi-tabs; but it's true that is not clearly defined in Coreboot/Linux coding style, so yes let's forget about this especially clang-format is coming.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib40e50d906aff05473a70c4fc9b124d63232558c
Gerrit-Change-Number: 32867
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 04 Jun 2019 01:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment