Attention is currently required from: Jes Klinke, Tim Wawrzynczak, Christian Walter, Angel Pons, Julius Werner, Jett Rink. Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Allow separate handling of Google Ti50 TPM ......................................................................
Patch Set 14:
(4 comments)
Patchset:
PS14: Updated to match refinements on the refactoring CL. I assume the "Merge conflict" is a result of the refactoring needed to be submitted first. I do not know if I can indicate to gerrit and Jenkins that the CL in the relation chain needs to be applied first, when testing this CL. (I would have thought that would be automatic, given the relation chain.)
PTAL
File src/drivers/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/46970edc_1a7366ea PS12, Line 112: 0;
nit: return `CB_SUCCESS` here instead of `0`
Done
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/63158/comment/69410712_8e2770d4 PS11, Line 32: MAINBOARD_HAS_I2C_TPM_TI50
Brask is also cr50 only
Tim, your comment is somewhat self-inconsistent, in that you use the word "also", while stating that Brask uses cr50, which is the opposite of the only two other variant.
I have changed the code such that variants Nissa and Brya are declared as using Ti50, and Brask is declared as using Cr50.
File src/mainboard/google/volteer/.history_*outside*:
PS12:
Is this meant to be committed?
Certainly not. Thanks for pointing this out, I have to stop my emacs from putting history files in random directories (and/or start paying attention to which files I "git add".)