Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43175 )
Change subject: mb/mainboard/dedede: support touchpad for Boten ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/boten/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 39: # USB Port Configuration : register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-C Port C0 : register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)" # Type-C Port C1 : register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 : register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A1 : register "usb2_ports[4]" = "USB2_PORT_MID(OC_SKIP)" # Discrete Bluetooth : register "usb2_ports[5]" = "USB2_PORT_EMPTY" # Not Used : register "usb2_ports[6]" = "USB2_PORT_EMPTY" # Not Used : register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Integrated Bluetooth No need to re-configure everything in devicetree. Override only those whose configurations differ from baseboard devicetree. Also do that in a separate CL so that this change covers only about enabling trackpad.
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 49: register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C0 : register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/2 Type-C Port C1 : register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/1 Type-A Port A0 : register "usb3_ports[3]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3/1 Type-A Port A1 : register "usb3_ports[4]" = "USB3_PORT_EMPTY" # Not Used : register "usb3_ports[5]" = "USB3_PORT_EMPTY" # Not Used No need to re-configure everything in devicetree. Override only those whose configurations differ from baseboard devicetree. Also do that in a separate CL so that this change covers only about enabling trackpad.
https://review.coreboot.org/c/coreboot/+/43175/2/src/mainboard/google/dedede... PS2, Line 142: chip drivers/i2c/generic : register "hid" = ""ELAN0000"" : register "desc" = ""ELAN Touchpad"" : register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" : register "wake" = "GPE0_DW0_03" : register "probed" = "1" : device i2c 15 on end : end : chip drivers/i2c/hid : register "generic.hid" = ""PNP0C50"" : register "generic.desc" = ""Synaptics Touchpad"" : register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" : register "generic.wake" = "GPE0_DW0_03" : register "generic.probed" = "1" : register "hid_desc_reg_offset" = "0x20" : device i2c 0x2c on end : end Which of these 2 trackpads is used and verified in Boten. Add the configuration for that trackpad alone in this change. Move everything else to a separate CL of their own.