Attention is currently required from: Evgeny Zinoviev, Martin L Roth.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76966?usp=email )
Change subject: mb/apple/macbookair4_2: Convert to Haswell-style SPD info ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Nit: If you combined all of these 'Add Haswell-style SPD info` changes into one or two commits, it w […]
I thought so too. Much of these are already combined as you can see. I would love to just combine all these into 4-5 mega patches:
one to redo all boards using MRC to just fill the fields like p8z77-m does, one to put in all the actual code changes into northbridge, with weak mainboard_get_spd() and mb_get_spd_map() to help avoid breakage during the transition, one to convert all boards en masse to mb_get_spd_map(), one to clean up the temporary transition stuff
I'm already restructuring this train this way.
Yet some apparently don't like seeing mega patches with too much going on, so this first train groups things by major differences: (native only/MRC capable) with (sockets only/soldered RAM).
Now I try to group patches into what the patches change, and hope for the best reception.
All said, I do like to see this, should we choose to accept it, incorporated for 4.22.