build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: [WIP] sb/intel/bd82x6x: Support ME Software Disable Mode ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... PS2, Line 254: else else is not generally useful after a break or return
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... PS2, Line 523: static void reset(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... PS2, Line 538: static void enable_soft_temp_disable_mode(void) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... PS2, Line 551: printk(BIOS_NOTICE, "ME: %s\n", __FUNCTION__); __func__ should be used instead of gcc specific __FUNCTION__
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... PS2, Line 561: __FUNCTION__); __func__ should be used instead of gcc specific __FUNCTION__
https://review.coreboot.org/c/coreboot/+/37115/2/src/southbridge/intel/bd82x... PS2, Line 564: static void disable_soft_temp_disable_mode(struct device *dev) { open brace '{' following function definitions go on the next line