Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48346 )
Change subject: azalia: Make `set_bits` function non-static
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48346/4/src/soc/intel/common/Kconfi...
File src/soc/intel/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/48346/4/src/soc/intel/common/Kconfi...
PS4, Line 3: select AZALIA_PLUGIN_SUPPORT
Yes, I need this since the azalia_device.c file is only built when this is selected.
Hmmm, can't decide... I would expect that there is some clean solution where
it doesn't get compiled when the board doesn't want to use it. It feels
wrong to select it at the chipset level. But I don't have the time to look
into it, right now. So I don't want to block this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48346
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff3520131ec7bc8554612969e3a2fe9cdbc9305e
Gerrit-Change-Number: 48346
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 14 Dec 2020 20:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment