Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41917 )
Change subject: acpi,mb/*: Use motherboard_fill_fadt() ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41917/2/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/fadt.c:
https://review.coreboot.org/c/coreboot/+/41917/2/src/mainboard/facebook/fbg1... PS2, Line 30:
Are these done?
Done
https://review.coreboot.org/c/coreboot/+/41917/2/src/mainboard/portwell/m107... File src/mainboard/portwell/m107/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/41917/2/src/mainboard/portwell/m107... PS2, Line 43: fadt->iapc_boot_arch &= ~ACPI_FADT_8042;
The fadt->preferred_pm_profile will not be set to PM_MOBILE for this board as this board is not defi […]
Done
https://review.coreboot.org/c/coreboot/+/41917/2/src/mainboard/protectli/vau... File src/mainboard/protectli/vault_bsw/acpi_tables.c:
https://review.coreboot.org/c/coreboot/+/41917/2/src/mainboard/protectli/vau... PS2, Line 34: }
The fadt->preferred_pm_profile will not be set to PM_MOBILE for this board as this board is not defi […]
Done