Attention is currently required from: Arthur Heymans, Chen, Gang C, Jincheng Li, Paul Menzel, Shuo Liu.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78331?usp=email )
Change subject: device/Kconfig: Add an option to allocate above 4G by default
......................................................................
Patch Set 16: Code-Review+1
(2 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/78331/comment/4b022842_097fc5ff :
PS16, Line 1012: config RESOURCE_IGNORE_FLAG_IORESOURCE_ABOVE_4G
I think this deserves a more positive naming. e.g. `ALWAYS_ALLOW_ABOVE_4G_ALLOCATION`.
https://review.coreboot.org/c/coreboot/+/78331/comment/61cf422e_0f44870a :
PS16, Line 1019: 32bit mode
Technically the incompatible mode is "flat protected mode", or we could
say "without paging". We do have some PAE code in coreboot, IIRC. So it's
actually possible to access above 4G.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78331?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I01218a8a3efc4a5f8ba344808949ca6b8898525f
Gerrit-Change-Number: 78331
Gerrit-PatchSet: 16
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Reviewer: Jincheng Li
jincheng.li@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Chen, Gang C
gang.c.chen@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jincheng Li
jincheng.li@intel.com
Gerrit-Comment-Date: Tue, 09 Jan 2024 12:31:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment