Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39344 )
Change subject: soc/intel/tigerlake: Fix ACPI path for GPIO
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi...
File src/soc/intel/tigerlake/gpio_tgl.c:
https://review.coreboot.org/c/coreboot/+/39344/5/src/soc/intel/tigerlake/gpi...
PS5, Line 128: No GCM2 device and group2 is not visible to kernel
Got it. Will implement that. […]
What is issue if CB returns correct ACPI path as "\_SB.PCI0.GCM2" and also make same change in
gpio.asl for group2. Will it cause Kernel issue? And group2 is not visable means kernel will not control group2 gpio either kernel driver or ACPI.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib03f6b26bafc304e531f2eaeeb0455b8333f1e44
Gerrit-Change-Number: 39344
Gerrit-PatchSet: 5
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Mar 2020 05:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shaunak Saha
shaunak.saha@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment