Attention is currently required from: Martin L Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68195 )
Change subject: soc/amd/morgana: Add initial commit for new SoC ......................................................................
Patch Set 3:
(13 comments)
File src/soc/amd/morgana/fsp_m_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/941ba256_80dd43fb PS3, Line 32: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/1a767399_e7cfe5f9 PS3, Line 45: for (i = 0; i < num; i++) { braces {} are not necessary for single statement blocks
File src/soc/amd/morgana/psp_verstage/svc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/fb9d85b9_9a09bf95 PS3, Line 12: #define SVC_CALL4(SVC_ID, R0, R1, R2, R3, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/393396e6_5897ceab PS3, Line 25: #define SVC_CALL3(SVC_ID, R0, R1, R2, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/0d1936b7_36738818 PS3, Line 36: #define SVC_CALL2(SVC_ID, R0, R1, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/2d4d5409_8b29a82c PS3, Line 46: #define SVC_CALL1(SVC_ID, R0, Ret) \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/6b7e4f3b_93d82e7e PS3, Line 55: #define SVC_CALL0(SVC_ID, Ret) \ Macros with complex values should be enclosed in parentheses
File src/soc/amd/morgana/root_complex.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/949b24e0_6f612441 PS3, Line 87: * | | X86_RESET_VECTOR = BOOTBLOCK_END - 0x10 line length of 98 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/d8e2c278_5fae07cd PS3, Line 90: * +--------------------------------+ BOOTBLOCK_ADDR = BOOTBLOCK_END - C_ENV_BOOTBLOCK_SIZE line length of 111 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/ec7ad983_dbb6328e PS3, Line 95: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE + 0x200 line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/dd638125_daec63cd PS3, Line 97: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE + PRERAM_CBMEM_CONSOLE_SIZE line length of 125 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/c64d7145_ed52a049 PS3, Line 100: * +--------------------------------+ PSP_SHAREDMEM_BASE + PSP_SHAREDMEM_SIZE line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-160013): https://review.coreboot.org/c/coreboot/+/68195/comment/c5059b9f_a7ef4495 PS3, Line 182: reserved_ram_resource_kb(dev, idx++, res->addr / KiB, res->length / KiB); line length of 97 exceeds 96 columns