Attention is currently required from: Hung-Te Lin, Rex-BC Chen.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57270 )
Change subject: soc/mediatek: reserve WDT reset reason for debugging
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57270/comment/5d939584_8f9d84c0
PS2, Line 10: reserve
do you mean preserve?
File src/soc/mediatek/common/wdt.c:
https://review.coreboot.org/c/coreboot/+/57270/comment/b6613331_4f5ff69d
PS2, Line 22: write32(&mtk_wdt->wdt_swrst, MTK_WDT_SWRST_KEY);
i'd replace this line with a do_board_reset() call which makes it much clearer what this is doing
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5887a8312f4daab3cbd0a30fea0195670a932e52
Gerrit-Change-Number: 57270
Gerrit-PatchSet: 2
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 17:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment