Attention is currently required from: Aseda Aboagye, Ivan Chen, Tim Wawrzynczak, Teddy Shih, Paul Fagerburg, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62801 )
Change subject: mb/google/dedede/var/beadrix: Enable LTE function by FW_CONFIG option
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/beadrix/gpio.c:
https://review.coreboot.org/c/coreboot/+/62801/comment/80f288bb_45c145f2
PS1, Line 91: BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL);
could fw_config_handle also be called directly from the mainboard code? i'd say that calling it via BOOT_STATE_INIT_ENTRY obfuscates the code flow a bit and without having looked closely into this i don't see a strong reason to use BOOT_STATE_INIT_ENTRY here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icea44992e2e3195d1fd9a888f5ce4650f82280bb
Gerrit-Change-Number: 62801
Gerrit-PatchSet: 1
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jack Cheng
jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 17 Mar 2022 14:35:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment