16 Jan
2019
16 Jan
'19
4:10 p.m.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30847 )
Change subject: mb/emulation/qemu-440fx: remove mm file listing ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/30847/4/src/mainboard/emulation/qemu-i440fx/... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/#/c/30847/4/src/mainboard/emulation/qemu-i440fx/... PS4, Line 62: uint32_t
size_t?
count refers to FWCfgFiles count (fw_cfg_if.h) which is an uint32_t. Reading more or less than 32 bit leads to problems.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30847
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie97ed3f0c98a5bb18a35ab0eaf8c4777a53e5779
Gerrit-Change-Number: 30847
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 15:10:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-MessageType: comment