Attention is currently required from: Henry Sun, Paul Fagerburg, Karthik Ramasubramanian.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55112 )
Change subject: mb/google/dedede/var/boten: Modify Wifi-SAR sku condition
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/boten/variant.c:
https://review.coreboot.org/c/coreboot/+/55112/comment/eb4de7e7_d09182e4
PS1, Line 33: if (sku_id >= SKU_ID_BOTENFLEX)
Is there an upper limit for the botenflex sku id? If so, can we add that in the check so that we don […]
Thanks for your suggestion.
The CL should cover all wifi-sar sku id condition since Boten sku id from 0x60000, and it won`t conflict with botenflex sku id(from 0x90000)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a4fb08e558fee26534564aa5e37cac814c5a98a
Gerrit-Change-Number: 55112
Gerrit-PatchSet: 1
Gerrit-Owner: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 21 Jun 2021 05:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment