Attention is currently required from: Matt DeVillier, Nick Vaccaro.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79960?usp=email )
Change subject: intel tgl mainboards: Move PcieRpEnable option below dt entries ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/volteer/variants/voema/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79960/comment/fd1265c4_c0018782 : PS1, Line 103: device ref pcie_rp7 off : register "PcieRpEnable[6]" = "0" : end
I assume this entry will go away once the PcieRpEnable is tied to the dt device status?
Right. The settings are mainly moved in order to make the review easier.
https://review.coreboot.org/c/coreboot/+/79960/comment/c20472cf_9590b684 : PS1, Line 108: probe DB_SD SD_GL9755S : probe DB_SD SD_RTS5261 : probe DB_SD SD_RTS5227S : probe DB_SD SD_GL9750 : probe DB_SD SD_OZ711LV2LN
why are you adding probe entries to a device that is off?
Afaik it's only the same device for sconfig if it contains the exact same configuration as the one from the upper levels. Otherwise it will conflict.