Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36867 )
Change subject: cbfs: Make cbfs_default_props() hidden again ......................................................................
cbfs: Make cbfs_default_props() hidden again
All the users that were needing cbfs_default_props() to remove code duplication are fixed. Therefore, there's no need to expose the symbol globally any longer.
Change-Id: Id84402b54ec1688e0c0adfa5c8fd12ce68ab8634 Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/include/cbfs.h M src/lib/cbfs.c 2 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/36867/1
diff --git a/src/include/cbfs.h b/src/include/cbfs.h index 60129d3..540a481 100644 --- a/src/include/cbfs.h +++ b/src/include/cbfs.h @@ -73,9 +73,6 @@ size_t size; };
-/* Default CBFS locator .locate() callback that locates "COREBOOT" region. */ -int cbfs_default_props(struct cbfs_props *props); - /* Return < 0 on error otherwise props are filled out accordingly. */ int cbfs_boot_region_properties(struct cbfs_props *props);
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index fbe6e43..44cda21 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -297,7 +297,7 @@ }
/* The default locator to find the CBFS in the "COREBOOT" FMAP region. */ -int cbfs_default_props(struct cbfs_props *props) +static int cbfs_default_props(struct cbfs_props *props) { struct region region;