Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40727 )
Change subject: intel/gma: Only enable bus mastering if we are going to use it
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/40727/4/src/northbridge/intel/haswe...
PS4, Line 468: if (!CONFIG(NO_GFX_INIT))
Does this reordering matter?
I wanted to group it with the gfxinit. The lines above are about general
silicon init.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40727
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib038f0cd558223536da08ba2264774db11cd8357
Gerrit-Change-Number: 40727
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 15:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment