Attention is currently required from: xin hua wang, Nicholas Chin, Evgeny Zinoviev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support
......................................................................
Patch Set 18:
(2 comments)
File src/mainboard/apple/macbookpro8_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/33151/comment/9bc7c615_8ea5705c
PS16, Line 32: subsystemid 0x8086 0x7270 inherit
I tried that, putting `subsystemid 0x8086 0x7270 inherit` inside the `chip southbrige` section, but […]
Ah, it only applies to devices. I don't think it's too much of an issue, then.
File src/mainboard/apple/macbookpro8_1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/33151/comment/35abad4d_45e9fb1f
PS11, Line 32: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS,
: GMA_INT15_PANEL_FIT_DEFAULT,
: GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
Does this work?
If this port hasn't been tested with an Intel VGA BIOS and without SeaBIOS, I'd drop the entire file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33151
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a7dc6d6c16751403ce276d2778dc915cd69f3f2
Gerrit-Change-Number: 33151
Gerrit-PatchSet: 18
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Martin L Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: xin hua wang
xinhuawang0101@gmail.com
Gerrit-Attention: xin hua wang
xinhuawang0101@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Comment-Date: Mon, 18 Apr 2022 00:04:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-MessageType: comment