Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45482 )
Change subject: payloads/external: add support for BOOTBOOT payload ......................................................................
Patch Set 3:
(2 comments)
Looks good but for some of the git foo.
https://review.coreboot.org/c/coreboot/+/45482/2/payloads/external/BOOTBOOT/... File payloads/external/BOOTBOOT/Makefile:
https://review.coreboot.org/c/coreboot/+/45482/2/payloads/external/BOOTBOOT/... PS2, Line 23: @test -d ../../../../bootboot && ln -s ../../../../bootboot 2>/dev/null || true This looks like a very local solution, maybe not suited for upstreaming?
https://review.coreboot.org/c/coreboot/+/45482/2/payloads/external/BOOTBOOT/... PS2, Line 29: git remote update ) ) Doing this as the last step looks odd. It wouldn't do anything to the checked out files, even if there are updates. Maybe start with a simple clone and then we can look into updates later? I've wasted some time on the topic myself (for other payloads) and still haven't come up with a fool-proof solution.