Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32928 )
Change subject: mb/{i945}: Drop CHANNEL_XOR_RANDOMIZATION selection ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Just remove the clutter, please.
https://review.coreboot.org/#/c/32928/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32928/2//COMMIT_MSG@7 PS2, Line 7: mb/{i945} The code changes are in `nb/intel/i945`.
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c... PS2, Line 2115: /* enable Channel XOR */ Please drop, the comment above supersedes it.
https://review.coreboot.org/#/c/32928/2/src/northbridge/intel/i945/raminit.c... PS2, Line 2118: #if 0 /* Channel XOR not supported? Bit[9:9] 0: Reserved */ : reg32 &= ~(1 << 9); : #endif Please drop it. I guess it should have set bit10 instead. Bit10 disables it, Bit9 configures which address bit is xor'ed if enabled.