Attention is currently required from: Nicholas Sudsgaard, Paul Menzel.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80332?usp=email )
Change subject: device/azalia: Clean up codec initialization code ......................................................................
Patch Set 5:
(4 comments)
File src/device/azalia_device.c:
https://review.coreboot.org/c/coreboot/+/80332/comment/bd94dec2_77c032da : PS5, Line 9: stdbool.h types.h
https://review.coreboot.org/c/coreboot/+/80332/comment/1caed32f_cbcdaffc : PS5, Line 230: static bool is "enum cb_err" can be used ? (commonlib/bsd/cb_err.h)
https://review.coreboot.org/c/coreboot/+/80332/comment/1cb10d31_b4685469 : PS5, Line 249: u32 Please, is "size_t' correct here?
File src/include/device/azalia_device.h:
https://review.coreboot.org/c/coreboot/+/80332/comment/00c120c5_083467a4 : PS5, Line 13: not sure, but I think those are intentional (same for line #18 & 19)