Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41436 )
Change subject: soc/amd/picasso: Add Kconfig option for the PSP bootloader filename
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/41436/1/src/soc/amd/picasso/Kconfig
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/41436/1/src/soc/amd/picasso/Kconfig...
PS1, Line 386: PspBootLoader_WL_RV
This file doesn't really exist in amd_blobs repo. Shouldn't this and PSP_WHITELIST_FILE be explicitly set by the mainboard when using it rather than having a default here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41436
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6597f7d4ffa0d48aead6974bd7111c987418f20
Gerrit-Change-Number: 41436
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 15 May 2020 21:57:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment