Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42947 )
Change subject: doc/mb/ocp: Add documentation for Delta Lake ......................................................................
Patch Set 2: Code-Review+1
(15 comments)
Thank you for the writing this. I noticed some minor things.
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/deltalake.md:
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 11: CooperLake Cooper Lake
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 17: Linuxboot LinuxBoot
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 22: CooperLake Cooper Lake
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 23: MP What is MP?
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 29: Linuxboot LinuxBoot
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 29: Linuxboot LinuxBoot
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 50: Linuxboot LinuxBoot
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 50: The solution is developed using Linuxboot payload. The Linuxboot : kernel versions tried is 5.2.9. The solution is developed using LinuxBoot payload with Linux kernel 5.2.9, and [u-root] as initramfs.
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 51: versions version
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 62: - Skipping memory training upon subsequent reboots … by using MRC cache.
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 73: its that
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 78: - VT-d is not supported. An IPS ticket is filed with Intel. I thought Linux can set that up.
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 81: with Intel. Use two spaces for consistency instead of tab?
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 86: that so
https://review.coreboot.org/c/coreboot/+/42947/2/Documentation/mainboard/ocp... PS2, Line 93: CooperLake Cooper Lake