Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45448 )
Change subject: nb/intel/gm45: Add more DMIBAR/EPBAR registers ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... File src/northbridge/intel/gm45/pcie.c:
https://review.coreboot.org/c/coreboot/+/45448/3/src/northbridge/intel/gm45/... PS3, Line 42: ;
I don't see that commit anywhere, I suppose it needs to be made?
It's what I fear may happen when the wrong person sees a semicolon on an empty line.
I however see CB:7683 which does the same as this patch, and also adds a comment.
Doesn't?
Having the semicolon on the same line as the `while` statement does not seem to be very popular, anyway:
SPARK is not very popular either.
grep -r "while (.*);" src/ | grep -v "} *while" | grep -v "#define" Compared to:
grep -r " ;" Note: the whitespace is a literal tab character.
Did anybody argue for the single line version? Personally, I like it, but understand if people don't.
The only winning move is not to play.
I thought I suggested three moves that might win... Why would you, for instance, say that a comment hurts?