16 Jul
2018
16 Jul
'18
12:50 p.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27416 )
Change subject: mediatek: Share GPIO code among similar SOCs ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/27416/3/src/soc/mediatek/common/include/soc/... File src/soc/mediatek/common/include/soc/gpio_common.h:
https://review.coreboot.org/#/c/27416/3/src/soc/mediatek/common/include/soc/... PS3, Line 19: #define PIN(index, name, func1, func2, func3, func4, func5, func6, func7) \ Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/27416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdd1f2a1dd1bd64a7218bf9c63bd4a0af1acbcc0
Gerrit-Change-Number: 27416
Gerrit-PatchSet: 3
Gerrit-Owner: Tristan Hsieh tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ting Shen phoenixshen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Jul 2018 15:50:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No